Lexer: Leading dot doesn’t close function passed as argument and not wrapped in parentheses

[bwiklund]

On 1.7.1, this breaks:

angular.module 'foo'
.controller 'EmailLoginCtrl', ->
.controller 'EmailSignupCtrl', ->

While this is fine:

angular.module 'foo'
.controller 'EmailLoginCtrl', (->)
.controller 'EmailSignupCtrl', (->)

And so is this:

angular.module 'foo'
.controller 'EmailLoginCtrl', -> return
.controller 'EmailSignupCtrl', -> return

Is this the way it's supposed to work?

[michaelficarra]

Related to and possibly duplicate of #1043. Fixed in CSR.

[xixixao]

Bug. I wouldn't call it a duplicate of 1043.

[joe-mojo]

Hey, do you think this one is related ?
with this code

Entity.find {$or: [{id:123}, {name: 'test'}]}
.sort {lastModified: -1}
.exec (err, data) ->
    #some code

you get :

Entity.find({
  $or: [
    {
      id: 123
    }, {
      name: 'test'
    }
  ]
}).sort({
  lastModified: -1
}.exec(function(err, data) {}));

instead of the expected :

Entity.find({
  $or: [
    {
      id: 123
    }, {
      name: 'test'
    }
  ]
}).sort({
  lastModified: -1
}).exec(function(err, data) {});

[TheLudd]

Are there plans for this? I have similair cases when using promises in my tests. I would like to be able to write:

beforeEach ->
  getPromise()
  .then (@result) =>
  .catch (@error) =>

[joe-mojo]

@TheLudd you last line is incorrect. See http://js2coffee.org/.

[TheLudd]

@joe-mojo
Yes? Isn't this an issue reporting that incorrectness as a bug? I said:

I would like to be able to write ....

as in "I am not able to do it now".

I expect the JavaScript equivalence of

getPromise().then(function() {}).catch(function() {})

(with the saving of the result and error parameters)

[joe-mojo]

@TheLudd
No, Your code is incorrect for Coffee. It is a nominal case.
Mine is a bug in Coffee 1.7.1. Yours won't work, even with Coffee 1.8 or 1.7.
Except if I missed something.

[xixixao]

@joe-mojo I think your case is a separate, similar bug. @TheLudd's case is caused by the reported bug.

@joe-mojo You are compiling with an old or wrong version of CoffeeScript. I just checked 1.7.1, 1.8 and master and they all compile your example as expected.

[TheLudd]

@joe-mojo Yes I know that my code does not work with any version of coffee script. I am asking if it is possible to make it work in future versions.

[GeoffreyBooth]

You’re really trying to spread across multiple lines what is really a one-line call. When you do so, you should use \, and parentheses as necessary:

angular.module('foo')\
.controller('EmailLoginCtrl', ->)\
.controller('EmailSignupCtrl', ->)

[lydell]

I still think this is a bug.