Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@CITIZENDOT
Copy link
Contributor

@CITIZENDOT CITIZENDOT commented Oct 10, 2023

Summary

🤖 Generated by Copilot at 7fe7c99

Added an optimization for volumetric video playback on iOS devices by adjusting the number of frames to request based on the iOS function in VolumetricComponent.ts.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at 7fe7c99

  • Import iOS function from isMobile module to check device type (link)
  • Add targetFramesToRequest property to V1Args object to specify how many frames to request from server (link)
  • Set targetFramesToRequest to 10 for iOS devices and 90 for other devices to optimize network and memory usage (link)

🤖 Generated by Copilot at 7fe7c99

To improve video playback on iOS
We imported a function that knows
How to set the target frames
In the V1Args names
And optimize the volumetric flows

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@speigg speigg added this pull request to the merge queue Oct 16, 2023
Merged via the queue into dev with commit 87ce21e Oct 16, 2023
@speigg speigg deleted the uvol-fix branch October 16, 2023 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants