Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@HexaField
Copy link
Contributor

@HexaField HexaField commented Apr 5, 2023

Summary

A summary of changes being made in this PR

References

closes #7363

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField linked an issue Apr 5, 2023 that may be closed by this pull request
@AidanCaruso
Copy link
Contributor

AidanCaruso commented Apr 18, 2023

Just tested this out with bubble pop. Switching the systems in bubble pop to the new definitions and visiting the location url yields these errors that prevent the location from loading:
image

I've run dev-reinit and made sure my modules are up to date. Have I made a mistake in setup?

@HexaField HexaField requested a review from speigg April 18, 2023 23:04
@HexaField HexaField merged commit 0402729 into dev Apr 19, 2023
@HexaField HexaField deleted the 7800-system-reference-counting-for-usesystemsinitsystems branch April 19, 2023 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System reference counting for useSystems/initSystems [RFC] System Execution Order

4 participants