This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Fixed some missing app.setup()'s in scripts. #7769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
force-pushed
the
static-resource-fixes
branch
from
4103d1c to
9f47027
Compare
The install-projects script was not calling app.setup() after creating the feathers app. With the new creation of assets when default-project is uploaded, this was causing the resulting find's with associations to fail because the associations were not set up. Saw a couple other scripts that had this problem as well, added there too. Added some legacy fallback for avatar urls.
barankyle
force-pushed
the
static-resource-fixes
branch
from
9f47027 to
bff9a52
Compare
speigg
approved these changes
Mar 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The install-projects script was not calling app.setup() after creating the feathers
app. With the new creation of assets when default-project is uploaded, this was
causing the resulting find's with associations to fail because the associations
were not set up.
Saw a couple other scripts that had this problem as well, added there too.
Added some support for legacy avatar url location on resources.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.