This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Image Compression + Conversion #7604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large files were choking feathers-sync and leading to irregular behavior. Added a FileBrowserService event for setting updateNeeded to true. upload.tsx now calls this on a slight delay so that the file browser can update after a file is uploaded through Import Asset/drag-and-drop.
…ompression-convert
![github-advanced-security[bot]](http://www.gproxx.com/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| data.mipmaps ? ' -mipmap' : '' | ||
| } -y_flip -linear -q ${data.quality} ${inPath}` | ||
| console.log(command) | ||
| console.log(await promiseExec(command)) |
Check warning
Code scanning / CodeQL
Shell command built from environment values
| } -y_flip -linear -q ${data.quality} ${inPath}` | ||
| console.log(command) | ||
| console.log(await promiseExec(command)) | ||
| console.log(await promiseExec(`mv ${fileName} ${outPath}`)) |
Check warning
Code scanning / CodeQL
Shell command built from environment values
Contributor
|
@dinomut1 let's fix the security vulnerabilities w/ shell commands that code scanning picked up |
speigg
approved these changes
Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model Transform Improvements:
Image Convert Service:
Reimplement file browser panel using hyperflux