Skip to content

fix(dynamic-links)!: remove Dynamic Links from React Native Firebase #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 30, 2025

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 29, 2025

Description

Once this is merged, I will follow up with a PR for other deprecations that ought to be removed.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 1:14pm

@russellwheatley russellwheatley changed the title fix: remove Dynamic Links from React Native Firebase fix(dynamic-links): remove Dynamic Links from React Native Firebase Jul 29, 2025
@russellwheatley russellwheatley changed the title fix(dynamic-links): remove Dynamic Links from React Native Firebase fix(dynamic-links)!: remove Dynamic Links from React Native Firebase Jul 29, 2025
@russellwheatley russellwheatley marked this pull request as ready for review July 30, 2025 13:43
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good - can't see anything I'd change, with small exception of logging a follow-up issue to be done after this is done to cleanup the eslint and patch generation exclusions which won't matter after merge (eslint) and release (patch generation)

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jul 30, 2025
@russellwheatley
Copy link
Member Author

post clean issue created here: #8635

@russellwheatley russellwheatley merged commit fe4550f into main Jul 30, 2025
18 checks passed
@russellwheatley russellwheatley deleted the remove-dynamic-links branch July 30, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants