Skip to content

Conversation

@thomasddn
Copy link
Contributor

@thomasddn thomasddn commented Dec 16, 2025

Proposed change

Add exterior and interior images of the user's vehicle as it actually is (colour, model, options, ...).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj
Copy link
Member

zweckj commented Dec 17, 2025

@MartinHjelmare I remember you had an opinion about static image entities

@thomasddn
Copy link
Contributor Author

I don't want to sound harsh and I say this with the deepest respect. There are a few opinions, but there doesn't seem to be a solution. See Discord here and here.

One offered alternative is creating (one?) entity_picture attribute on an existing entity. However, users cannot use that in a picture card, which is the main goal of these images. They would have to create a template helper, which in the end just creates... an image entity. It's more steps with the same end result.

I believe offering static pictures is a valid use case. Especially in this case, for this kind of integration, where (1) the image is user-specific (an actual representation of their own vehicle) and (2) the image URL's are only provided by the API. Users are clearly asking for this as can be seen in the linked issue.

Would it make any difference with one, or a combination, of the following tweaks?

  • Disable by default
  • Only one image entity, and adding an option to let the user choose which image they want

@WebSpider
Copy link
Contributor

👀 tracking this as we do this in the MySkoda custom integration as well, and we might want to become part of core.

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Dec 17, 2025

Our general rule is that we don't allow static data in the state machine.

In the core meeting we discussed this architecture discussion and we want to investigate that after the new device model is in place:

home-assistant/architecture#1207

If you want to allow users to use the URLs before the above solution gets closer to realization, I think a service action that returns URLs would not be contrary to any current design decisions.

@MartinHjelmare MartinHjelmare marked this pull request as draft December 17, 2025 13:56
@thomasddn thomasddn closed this Dec 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2025
@karwosts
Copy link
Member

I see you're proceeding with your service, but I'll mention two other possibilities in case you're interested in them as well.

  • You can implement a media_source of all your images, and user can display media_source images in a picture card.
  • We could explore allowing picture card to directly display an entity_picture. We already do this for some domains (like person), so it wouldn't be a big stretch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add volvo images

5 participants