Skip to content

Add update platform to template integration #150277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 25, 2025
Merged

Add update platform to template integration #150277

merged 7 commits into from
Aug 25, 2025

Conversation

Petro31
Copy link
Contributor

@Petro31 Petro31 commented Aug 8, 2025 •
edited
Loading

Breaking change

Proposed change

Add update platform to template integration

e.g.

template:
- update:
  - name: ...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Petro31 Petro31 requested a review from a team as a code owner August 8, 2025 13:37
@home-assistant
Copy link

home-assistant bot commented Aug 8, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign template Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

NoRi2909
NoRi2909 reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@NoRi2909 NoRi2909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small issues.

joostlek
joostlek previously requested changes Aug 8, 2025
View reviewed changes
homeassistant/components/template/config_flow.py
vol.Optional(CONF_IN_PROGRESS): selector.TemplateSelector(),
vol.Optional(CONF_RELEASE_SUMMARY): selector.TemplateSelector(),
vol.Optional(CONF_RELEASE_URL): selector.TemplateSelector(),
vol.Optional(CONF_TITLE): selector.TemplateSelector(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now actually wondering what we use the title for

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's for the title of the update message that appears.

homeassistant/components/template/update.py
Comment on lines +296 to +298
# The default picture for update entities would use `self.platform.platform_name` in
# place of `template`. This does not work when creating an entity preview because
# the platform does not exist for that entity, therefore this is hardcoded as `template`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this set via _attr_entity_picture or by overwriting the property?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the upstream entity overrides the property unfortunately, which leads to odd behavior. That's why I went this route, to account for that odd behavior. I originally tried to do everything without these properties via the _attr_entity_picture.

@home-assistant
Copy link

home-assistant bot commented Aug 8, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 8, 2025 19:26
@Petro31 Petro31 marked this pull request as ready for review August 9, 2025 12:11
@home-assistant home-assistant bot requested a review from joostlek August 9, 2025 12:11
emontnemery
emontnemery reviewed Aug 20, 2025
View reviewed changes
@Petro31 Petro31 mentioned this pull request Aug 20, 2025
Merged
8 tasks
emontnemery
emontnemery approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Petro31 👍

@emontnemery emontnemery merged commit 58d4fd0 into home-assistant:dev Aug 25, 2025
48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@emontnemery emontnemery emontnemery approved these changes

@joostlek joostlek Awaiting requested review from joostlek

+1 more reviewer

@NoRi2909 NoRi2909 NoRi2909 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

by-code-owner cla-signed has-tests integration: template new-feature new-platform Quality Scale: internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Petro31 @joostlek @emontnemery @NoRi2909