Skip to content

Conversation

arturpragacz
Copy link
Contributor

@arturpragacz arturpragacz commented Aug 7, 2025

Proposed change

Improve UNPAIR_SERVICE_SCHEMA in homekit.

As this service required just devices, using ENTITY_SERVICE_FIELDS was unnecessarily complex. Additionally a device selector provides a better UI here than target selector.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 22:40
@arturpragacz arturpragacz requested a review from bdraco as a code owner August 7, 2025 22:40
@home-assistant
Copy link

home-assistant bot commented Aug 7, 2025

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the HomeKit unpair service schema by simplifying the validation and adding proper field documentation. The changes make the device_id parameter explicitly required and provide user-friendly descriptions for the service and its fields.

Key changes:

  • Simplified the unpair service schema validation to directly require device_id as a string
  • Added proper field documentation in strings.json for the device_id parameter
  • Updated services.yaml to use fields instead of target with proper device selector

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/homekit/__init__.py Simplified UNPAIR_SERVICE_SCHEMA to directly require device_id as string instead of using complex entity service validation
homeassistant/components/homekit/services.yaml Changed from target-based to fields-based schema with required device_id and device selector
homeassistant/components/homekit/strings.json Added field documentation for device_id parameter in the unpair service

@arturpragacz arturpragacz requested a review from joostlek August 19, 2025 16:21
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works as expected

Screenshot 2025-09-01 at 9 56 58 AM

@bdraco bdraco merged commit c4fce1c into home-assistant:dev Sep 1, 2025
31 checks passed
@frenck frenck added this to the 2025.9.0 milestone Sep 1, 2025
@frenck
Copy link
Member

frenck commented Sep 1, 2025

Tagged this for the current beta, nice little QoL.

@arturpragacz arturpragacz deleted the homekit/improve-unpair-service-schema branch September 1, 2025 15:02
frenck pushed a commit that referenced this pull request Sep 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants