[component/onvif] remove default value of continuous_duration to support devices which do not implement "stop" #150183
+11
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Using onvif.ptz to control cameras which do not fully support the onvif spec.
I have 2 cameras which can only be controlled using
ContinuousMove
and do not implementStop
.To stop them it is nececcary to send another
ContinuousMove
with a distance of 0.With a the change in this pr the default value of
continuous_duration
is removed andStop
is only called whencontinuous_duration
is set.ptz works nicely on a boifun/cloudedge/iegeek babycam using something like:
also just noticed right now:
#145811 fixes the issue as well (but different)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: