Skip to content

Conversation

yoxcu
Copy link

@yoxcu yoxcu commented Aug 7, 2025

Proposed change

Using onvif.ptz to control cameras which do not fully support the onvif spec.
I have 2 cameras which can only be controlled using ContinuousMove and do not implement Stop.
To stop them it is nececcary to send another ContinuousMove with a distance of 0.

With a the change in this pr the default value of continuous_duration is removed and Stop is only called when continuous_duration is set.

ptz works nicely on a boifun/cloudedge/iegeek babycam using something like:

type: custom:advanced-camera-card
cameras:
  - camera_entity: camera.babycam_profile_000
    live_provider: auto
    ptz:
      actions_left_start:
        action: perform-action
        perform_action: onvif.ptz
        data:
          entity_id: camera.babycam_profile_000
          pan: LEFT
          distance: 1
          move_mode: ContinuousMove
      actions_left_stop:
        action: perform-action
        perform_action: onvif.ptz
        data:
          entity_id: camera.babycam_profile_000
          pan: LEFT
          distance: 0
          move_mode: ContinuousMove

also just noticed right now:
#145811 fixes the issue as well (but different)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@yoxcu yoxcu requested a review from hunterjm as a code owner August 7, 2025 11:48
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yoxcu

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Aug 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 7, 2025 11:48
@home-assistant
Copy link

home-assistant bot commented Aug 7, 2025

Hey there @hunterjm, @jterrace, mind taking a look at this pull request as it has been labeled with an integration (onvif) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onvif can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onvif Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@yoxcu yoxcu marked this pull request as ready for review August 7, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONVIF error when panning camera: "Failed to perform the action onvif/ptz. Action Not Implemented"
3 participants