Skip to content

Conversation

zzysszzy
Copy link
Contributor

Breaking change

This change updates the entity name for the reverse energy sensor in Tuya zndb smart meters from "Total energy" to "Total production". Users may need to update any automations or dashboards that reference the old entity name.

Proposed change

This PR improves the naming clarity for Tuya zndb smart meter reverse energy sensors. The current implementation uses the generic total_energy translation key for the REVERSE_ENERGY_TOTAL sensor, which can cause confusion when smart meters have both energy consumption and energy production sensors.

The change updates the translation key from "total_energy" to "total_production" for the reverse energy sensor in zndb category devices. This provides clearer distinction between energy consumed from the grid versus energy produced/fed back to the grid (e.g., from solar panels).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@zzysszzy zzysszzy force-pushed the feature/translation-key branch from f5154cb to a7c342d Compare July 29, 2025 10:08
@zzysszzy zzysszzy force-pushed the feature/translation-key branch from 99d80a5 to 2fac1b4 Compare July 29, 2025 10:50
@zzysszzy
Copy link
Contributor Author

@epenet Please help review this very minor PR.

@epenet epenet marked this pull request as draft July 30, 2025 10:49
@epenet epenet changed the title Tuya: Update zndb reverse energy sensor translation key to "total_production" Update tuya translation for reverse energy sensor Jul 30, 2025
@zzysszzy zzysszzy marked this pull request as ready for review August 7, 2025 14:56
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Congratulations @zzysszzy on your first PR

@epenet epenet merged commit ff9e2a8 into home-assistant:dev Aug 7, 2025
34 checks passed
@zzysszzy
Copy link
Contributor Author

zzysszzy commented Aug 7, 2025

LGTM 👍

Congratulations @zzysszzy on your first PR

Thanks a lot for your review and guidance on my first PR~~

@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong device category assigned in Tuya
3 participants