Cannot initialise with Terraform AWS Provider version 6

[paulschwarzenberger]

Cannot initialise with Terraform AWS Provider v 6.0.0

This is due to a provider constraint at https://github.com/github-aws-runners/terraform-aws-github-runner/blob/main/modules/webhook/eventbridge/versions.tf

    aws = {
      source  = "hashicorp/aws"
      version = "~> 5.0"
    }

[paulschwarzenberger]

there are also a couple of other pinned versions in submodules

[GuptaNavdeep1983]

@paulschwarzenberger Is there any particular need for using this provider version?

[paulschwarzenberger]

As of 18 June this is the default version, we've already upgraded our internal modules used by the same parent repository to support v6, some of these now require >=6.0.0. We have also upgraded to the latest version 6.0.0 of the AWS VPC module which has a version constraint >=5.79 that is also incompatible with this self-hosted runners module.

[npalm]

Thx for catching the problem. Would you have time to make a PR with a fix?

[paulschwarzenberger]

Possibly, so I can estimate how much work is involved, I'd like to check whether you agree with my proposed approach, and also if my understanding of the changes needed is correct.

I've already tested a fork with provider constraints updated to allow version 6, using a default configuration, this deployed successfully.

I believe the requirements for this PR should be:

• support Terraform AWS Provider v6
• continue to support Terraform AWS Provider v5 for as long as practical
• avoid the need for another issue to be raised when v7 is eventually released

Therefore, I propose the following:

• replace current constraints in versions.tf ~> 5.0, ~> 5.27, ~> 5.77 in the module and submodules with >=5.0, >=5.27, >=5.77
• this follows similar practice adopted by many other popular AWS Terraform modules, e.g. the AWS VPC
• in the examples, upgrade versions.tf to ">=6.0" except for two of the examples, suggest multi-runner and permission-boundary where it's left as is, with a comment ensure backwards compatibility with v5.x
• terraform.lock.hcl files will be updated automatically by pipeline
• in the unlikely event of v6 deprecation issues on Terraform plan, ignore, as fixing them would likely break v5

Please let me know what you think.

[claytonolley]

I just did a quick test in my environments and all showed no changes with v6. I don't use every submodule however.