fix(aci): Report groups absent from results and treat them as non-triggering #95502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
approved these changes
Jul 14, 2025
| # If we didn't get complete query results, don't fire. | ||
| metrics.incr("workflow_engine.delayed_workflow.missing_query_result") | ||
| logger.warning( | ||
| "workflow_engine.delayed_workflow.missing_query_result", exc_info=True |
There was a problem hiding this comment.
Will UniqueConditionQuery be splatted in a readable manner into the logs? It's a dataclass and has a __repr__ but I'm not sure how/if exc_info uses it
There was a problem hiding this comment.
I'm not completely sure, I think so, but it's also in the logs a bit earlier in this case, so I'm okay to wait and see.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95502 +/- ##
==========================================
+ Coverage 77.34% 84.11% +6.77%
==========================================
Files 10534 10538 +4
Lines 607326 607433 +107
Branches 23801 23801
==========================================
+ Hits 469745 510956 +41211
+ Misses 137286 96182 -41104
Partials 295 295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we request data from Snuba for a group but don't get anything back.
This is a problem, but it shouldn't keep other groups with full data from being evaluated.
Fixes ACI-423