ref(preprod): Add LaunchpadRpcPermission #100479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
chromy
force-pushed
the
chromy/2025-09-28-add-permission
branch
from
8e2fe07 to
2d2e55c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100479 +/- ##
============================================
+ Coverage 69.40% 81.12% +11.71%
============================================
Files 8587 8593 +6
Lines 380553 380823 +270
Branches 23889 23889
============================================
+ Hits 264134 308949 +44815
+ Misses 116057 71512 -44545
Partials 362 362 |
chromy
force-pushed
the
chromy/2025-09-28-add-permission
branch
from
2d2e55c to
ab53657
Compare
trevor-e
approved these changes
Sep 29, 2025
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
chromy
force-pushed
the
chromy/2025-09-28-add-permission
branch
from
b545230 to
325f78b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
LaunchpadRpcPermissionand update preprod endpoints to use it instead of a custom check in each endpoint.This also closes a bug where the /size/ endpoint required some authentication - but not specifically the
LaunchpadRpcSignatureAuthenticationdue to missing the manual check. Also add a test to prove this now works.