macOS: Improve menu item handling and add traditional fullscreen shortcut#2228
Merged
flyinghead merged 1 commit intoflyinghead:masterfrom Feb 10, 2026
Merged
Conversation
vkedwardli
force-pushed
the
fix-macos-keyboardshortcuts
branch
from
abfc872 to
c01bbe0
Compare
vkedwardli
force-pushed
the
fix-macos-keyboardshortcuts
branch
from
c01bbe0 to
995f4a8
Compare
Collaborator
Author
|
Removed unused Apple Help menu item also |
vkedwardli
commented
Feb 2, 2026
|
|
||
| menuItem = (NSMenuItem *)[appleMenu addItemWithTitle:@"Hide Others" action:@selector(hideOtherApplications:) keyEquivalent:@"h"]; | ||
| [menuItem setKeyEquivalentModifierMask:(NSAlternateKeyMask|NSCommandKeyMask)]; | ||
| [menuItem setKeyEquivalentModifierMask:(NSEventModifierFlagOption | NSEventModifierFlagCommand)]; |
Collaborator
Author
There was a problem hiding this comment.
Update deprecations only, no logic change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User reported that he cannot go fullscreen by keyboard shortcut when he is not using an Apple keyboard.
Ctrl + Cmd + Fwas the standard Full Screen shortcut from OS X 10.7 Lion through macOS 11 Big Sur,Globe + FandCtrl + Cmd + FToggle Menuwhen there is no command menu for togglingToggle Menuto Cmd + Shift + M to avoid clashing withMinimize