Skip to content

Changed to not require RFF update when new FF config props are added #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

erikras
Copy link
Member

@erikras erikras commented Jun 6, 2018

Also adds UNSAFE_ prefixes to fix #267.

Includes react-lifecycles-compat as described on the React blog.

@ghost ghost assigned erikras Jun 6, 2018
@ghost ghost added the in progress label Jun 6, 2018
@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #272 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #272   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         205    200    -5     
  Branches       61     59    -2     
=====================================
- Hits          205    200    -5
Impacted Files Coverage Δ
src/FormSpy.js 100% <ø> (ø) ⬆️
src/Field.js 100% <ø> (ø) ⬆️
src/ReactFinalForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c9208...393268c. Read the comment docs.

@erikras erikras merged commit ccdf641 into master Jun 6, 2018
@ghost ghost removed the in progress label Jun 6, 2018
@erikras erikras deleted the config-lubrication branch June 6, 2018 14:16
@jarrodpayne
Copy link

@erikras I see the included react-lifecycles-compat dependency, but don't see it being used anywhere. Am I missing something, or is the commit missing the use of this dep?

@erikras
Copy link
Member Author

erikras commented Jun 14, 2018

Ha! Looks like I overlook actually using it. 🤦‍♂️

@lock
Copy link

lock bot commented Jul 14, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using componentWillReceiveProps, componentWillUpdate lifecycle methods
2 participants