Skip to content

Conversation

@passsy
Copy link
Contributor

@passsy passsy commented Oct 19, 2025

Building on top of #117

tested it all day, it works fine :)

The versioning and breaking changes (like raising min-sdk) need to be considered

StarProxima and others added 13 commits August 15, 2025 19:26
- fresh: 0.4.3 -> 0.5.0
- fresh_dio: 0.4.3 -> 0.5.0
- fresh_graphql: 0.6.1 -> 0.7.0
- Replace AuthToken with Token base class
- Remove automatic issuedAt setting in FreshMixin
- Update OAuth2Token to extend Token instead of AuthToken
- Remove outdated tests for copyWith and automatic issuedAt
- Update changelogs to remove breaking change mentions

Token architecture is now extensible without breaking changes.
@passsy passsy requested a review from felangel as a code owner October 19, 2025 20:01
@passsy passsy changed the title feat: Enhanced token management with proactive validation and expiration support feat: Actually land: Enhanced token management with proactive validation and expiration support Oct 19, 2025
@felangel felangel added the enhancement New feature or request label Oct 19, 2025
@felangel
Copy link
Owner

Thanks I'll take a closer look later either today or tomorrow and try to get this merged. Really appreciate you taking the time to ship these improvements 💯

@felangel
Copy link
Owner

Also @passsy curious what your thoughts are on the changes in #112 since that branch includes a much smaller diff while still attempting to address #110? We have some users already using that branch in production successfully.

@passsy
Copy link
Contributor Author

passsy commented Oct 19, 2025

I much preferred expiresAt being part of the Token instead of isExpired on the TokenStorage

@StarProxima
Copy link

@passsy Hi, can you go back to that?

@passsy passsy force-pushed the pull-validate-token-from-StarProxima branch from 059865d to c4bfdcc Compare January 7, 2026 17:15
# Conflicts:
#	packages/fresh/CHANGELOG.md
#	packages/fresh/pubspec.yaml
#	packages/fresh_dio/CHANGELOG.md
#	packages/fresh_dio/pubspec.yaml
@passsy
Copy link
Contributor Author

passsy commented Jan 7, 2026

PR is ready. CI fails with

Because fresh_dio depends on fresh ^0.5.0 which doesn't match any versions,

Which will resolve when fresh: 0.5.0 is published

# Conflicts:
#	packages/fresh_dio/CHANGELOG.md
#	packages/fresh_dio/lib/src/fresh.dart
#	packages/fresh_dio/pubspec.yaml
@felangel
Copy link
Owner

Thanks planning to spend some time getting this merged and published tomorrow!

@passsy
Copy link
Contributor Author

passsy commented Jan 22, 2026

friendly push @felangel ❤️

@felangel
Copy link
Owner

friendly push @felangel ❤️

Sorry for the delay! Thanks for the bump, I’ll try to get this done this evening 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants