-
-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Actually land: Enhanced token management with proactive validation and expiration support #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Actually land: Enhanced token management with proactive validation and expiration support #121
Conversation
- fresh: 0.4.3 -> 0.5.0 - fresh_dio: 0.4.3 -> 0.5.0 - fresh_graphql: 0.6.1 -> 0.7.0
- Replace AuthToken with Token base class - Remove automatic issuedAt setting in FreshMixin - Update OAuth2Token to extend Token instead of AuthToken - Remove outdated tests for copyWith and automatic issuedAt - Update changelogs to remove breaking change mentions Token architecture is now extensible without breaking changes.
|
Thanks I'll take a closer look later either today or tomorrow and try to get this merged. Really appreciate you taking the time to ship these improvements 💯 |
|
I much preferred |
|
@passsy Hi, can you go back to that? |
059865d to
c4bfdcc
Compare
# Conflicts: # packages/fresh/CHANGELOG.md # packages/fresh/pubspec.yaml # packages/fresh_dio/CHANGELOG.md # packages/fresh_dio/pubspec.yaml
|
PR is ready. CI fails with Which will resolve when |
# Conflicts: # packages/fresh_dio/CHANGELOG.md # packages/fresh_dio/lib/src/fresh.dart # packages/fresh_dio/pubspec.yaml
|
Thanks planning to spend some time getting this merged and published tomorrow! |
|
friendly push @felangel ❤️ |
Sorry for the delay! Thanks for the bump, I’ll try to get this done this evening 👍 |
Building on top of #117
tested it all day, it works fine :)
The versioning and breaking changes (like raising min-sdk) need to be considered