Add COMPILE_DEPENDENCIES build setting#8393
Closed
DylanVann wants to merge 2 commits intofacebook:masterfrom
Closed
Add COMPILE_DEPENDENCIES build setting#8393DylanVann wants to merge 2 commits intofacebook:masterfrom
DylanVann wants to merge 2 commits intofacebook:masterfrom
Conversation
DylanVann
requested review from
amyrlam,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a setting to disable the running of
babel-loaderon dependencies.Adding
babel-loaderon dependencies significantly impacts build time. The impact of this can be up to an extra minute.This PR reads the
COMPILE_DEPENDENCIESenvironment variable.truethen compile dependencies as is done now.babel-loaderfor dependencies.This is adding more configuration, and may not be in line with the direction of CRA (less config), but it could help people experiencing high build times who know their dependencies do not contain code breaking in their target browsers.