ensure that vc-deduce-backend works correctly in all cases #2735
Conversation
|
Quang Trung Ta ***@***.***> writes:
Hi,
This is a small fix to ensure that the setting (setq vc-deduce-backend-nonvc-modes t) in your comment is always met.
I don't think this is needed, as it is a user var one can set this in
their conf file (as I do), thus I guess such configuration is very rare,
with default emacs settings it should work fine.
I need such configuration because I load 100/200 buffer at emacs start
and this make it much faster (vc is slow).
… #2732 (comment)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
You can view, comment on, or merge this pull request online at:
#2735
Commit Summary
• c493e8d ensure that vc-deduce-backend works correctly in all cases
File Changes
(1 file)
• M helm-files.el (2)
Patch Links:
• https://github.com/emacs-helm/helm/pull/2735.patch
• https://github.com/emacs-helm/helm/pull/2735.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.*Message ID: ***@***.***>
--
Thierry
|
|
Just a comment on what I experienced previously, if I keep This can happen, for example, when I just create a new file and haven't included it in the Git repo yet. So, I think this PR is a safe fallback in the case that users aren't aware that they need to set |
|
Quang Trung Ta ***@***.***> writes:
● taquangtrung left a comment (emacs-helm/helm#2735)
Just a comment on what I experienced previously, if I keep vc-deduce-backend-nonvc-modes as the default value, then (vc-deduce-backend) will return Nil on Git-untracked files.
This can happen, for example, when I just create a new file and haven't included it in the Git repo yet.
So, I think this PR is a safe fallback in the case that users aren't aware that they need to set vc-deduce-backend-nonvc-modes to t.
So it is the same as always using
(vc-responsible-backend default-directory) instead of
(vc-deduce-backend), it is what you want I think.
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.*Message ID: ***@***.***>
--
Thierry
|
What you said is right, setting Now I'm not sure if this PR is the right fix for the issue of Git-untracked files that I encountered 😅 |
|
Quang Trung Ta ***@***.***> writes:
● taquangtrung left a comment (emacs-helm/helm#2735)
Quang Trung Ta @.*> writes:
● taquangtrung left a comment (emacs-helm/helm#2735) Just a comment on what I experienced previously, if I keep vc-deduce-backend-nonvc-modes as the default value, then
(vc-deduce-backend) will return Nil on Git-untracked files. This can happen, for example, when I just create a new file and haven't included it in the Git repo yet. So, I think this PR
is a safe fallback in the case that users aren't aware that they need to set vc-deduce-backend-nonvc-modes to t.
So it is the same as always using (vc-responsible-backend default-directory) instead of (vc-deduce-backend), it is what you want I think.
…
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.>
-- Thierry
What you said is right, setting vc-deduce-backend-nonvc-modes to t also means that always call (vc-responsible-backend default-directory).
Now I'm not sure if this PR is the right fix for the issue of Git-untracked files that I encountered 😅
From where I stand, it looks good, it is what I need, it will change nothing, think
at what you need exactly, take your time there is no hurry on this one ;-)
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.*Message ID: ***@***.***>
--
Thierry
|
Hi,
This is a small fix to ensure that the setting
(setq vc-deduce-backend-nonvc-modes t)in your comment is always met.#2732 (comment)