Skip to content

[ti_misp] Add missing event.original cleanup step for threat_attributes data stream.#6218

Merged
marc-gr merged 2 commits intoelastic:mainfrom
marc-gr:fix/misp_threat_attributes_event.riginal
May 17, 2023
Merged

[ti_misp] Add missing event.original cleanup step for threat_attributes data stream.#6218
marc-gr merged 2 commits intoelastic:mainfrom
marc-gr:fix/misp_threat_attributes_event.riginal

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 16, 2023

What does this PR do?

Adds missing event.original cleanup in threat_attributes data stream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr force-pushed the fix/misp_threat_attributes_event.riginal branch from ead1ae6 to 9a7c8a5 Compare May 16, 2023 08:28
@marc-gr marc-gr marked this pull request as ready for review May 16, 2023 08:28
@marc-gr marc-gr requested a review from a team as a code owner May 16, 2023 08:28
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-17T08:41:22.756+0000

  • Duration: 14 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (30/30) 💚 5.814
Lines 86.344% (607/703) 👎 -13.656
Conditionals 100.0% (0/0) 💚

@marc-gr marc-gr requested a review from chemamartinez May 17, 2023 08:46
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit dc05846 into elastic:main May 17, 2023
@marc-gr marc-gr deleted the fix/misp_threat_attributes_event.riginal branch May 17, 2023 09:03
@elasticmachine
Copy link

Package ti_misp - 1.14.1 containing this change is available at https://epr.elastic.co/search?package=ti_misp

1 similar comment
@elasticmachine
Copy link

Package ti_misp - 1.14.1 containing this change is available at https://epr.elastic.co/search?package=ti_misp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:ti_misp MISP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants