Skip to content

Conversation

@rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 4, 2023

  • Enhancement

What does this PR do?

  • Migrate [Logs Nginx] Overview dashboard visualizations to lens for Nginx integration package

  • Statistics for Nginx Lens migration:

Nginx Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs Nginx] Overview 0 8 7 1 (Markdown)
  0 8 7 1 (Markdown)

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.5.0 itself.

Related issues

Note:
In the Response codes over time [Logs Nginx] we faced below two issues:

  1. Lens doesn't have a gradient color palette.
    Solution: Set the color palette to status color palette because the values are defined by response status codes.
  2. We are unable to set http.response.status_code: [200 TO 299] filters due to number_format_exception.
    Solution: To overcome this issue we have set the filter as http.response.status_code >= 200 and http.response.status_code<= 299.

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 4, 2023 09:22
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 4, 2023
7 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:nginx Nginx v8.5.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 4, 2023
@kush-elastic kush-elastic self-requested a review April 4, 2023 09:33
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T05:44:59.468+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👍
Classes 50.0% (2/4) 👍
Methods 69.231% (27/39) 👍
Lines 70.37% (228/324) 👍
Conditionals 100.0% (0/0) 💚

@milan-elastic
Copy link
Contributor

Approved!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove [Logs Nginx] phrase from the cangelog

@rajvi-patel-22
Copy link
Contributor Author

Please remove [Logs Nginx] phrase from the cangelog

@agithomas, I'll remove the [Logs Nginx] phrase but there are two overview dashboards in Nginx.

  1. [Logs Nginx] Overview
  2. [Metrics Nginx] Overview

So, It would be good to keep Logs Overview and Metrics Overview in the description. What do you think?

@agithomas
Copy link
Contributor

Please remove [Logs Nginx] phrase from the cangelog

@agithomas, I'll remove the [Logs Nginx] phrase but there are two overview dashboards in Nginx.

  1. [Logs Nginx] Overview
  2. [Metrics Nginx] Overview

So, It would be good to keep Logs Overview and Metrics Overview in the description. What do you think?

Suggestions are just fine.

@rajvi-patel-22 rajvi-patel-22 requested a review from agithomas April 5, 2023 10:16
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit b765895 into elastic:main Apr 6, 2023
@elasticmachine
Copy link

Package nginx - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:nginx Nginx Team:Service-Integrations Label for the Observability Service Integrations team v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants