Skip to content

elasticsearch/index_recovery: fix version field mapping #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 1 commit into from
Mar 30, 2022
Merged

elasticsearch/index_recovery: fix version field mapping #2896

efd6 merged 1 commit into from
Mar 30, 2022

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Mar 28, 2022 •
edited by andrewkroh
Loading

What does this PR do?

elasticsearch index_recovery data stream has version mapped as long in package-fields.yml and system auth data_stream has version mapped as keyword in fields.yml. This changes elasticsearch to use keyword.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:system System Integration:elasticsearch Elasticsearch labels Mar 28, 2022
@elasticmachine
Copy link

elasticmachine commented Mar 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-28T21:11:03.361+0000

  • Duration: 14 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 marked this pull request as ready for review March 28, 2022 05:32
@efd6 efd6 requested a review from a team as a code owner March 28, 2022 05:32
@elasticmachine
Copy link

elasticmachine commented Mar 28, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added the Team:Integrations Label for the Integrations team label Mar 28, 2022
@elasticmachine
Copy link

elasticmachine commented Mar 28, 2022

Pinging @elastic/integrations (Team:Integrations)

@andrewkroh andrewkroh requested a review from a team March 29, 2022 13:19
klacabane
klacabane approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 2aee5ee into elastic:main Mar 30, 2022
@efd6 efd6 deleted the elasticsearch branch March 30, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klacabane klacabane klacabane approved these changes

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues Integration:elasticsearch Elasticsearch Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[elasticsearch] [system] Conflicting version field definition

4 participants

@efd6 @elasticmachine @klacabane @andrewkroh