Update kubernetes namespace field. breaking change#1792
Update kubernetes namespace field. breaking change#1792MichaelKatsoulis merged 4 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/integrations (Team:Integrations) |
|
This needs to be merged after elastic/beats#27917 is merged |
| name: kubernetes | ||
| title: Kubernetes | ||
| version: 1.1.0 | ||
| version: 1.2.0 |
There was a problem hiding this comment.
If this is a breaking change, you should go with 2.0.0
packages/kubernetes/data_stream/controllermanager/fields/base-fields.yml
Show resolved
Hide resolved
| - version: "1.2.0" | ||
| changes: | ||
| - description: Update Kubernetes namespace field | ||
| type: enhancement |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Can you share some details on how a user is upgrading from 7.x to 8.0 and the order a user would upgrade? I see now changes to the ingest pipeline in this PR but would have expected the ingest pipeline to provide some backward compatbility. |
|
@mtojek I added the ingest pipelines to support old agent versions as well! I think that now it is not considered a breaking change for the package anymore. So we don't need to set the version to 2.0 and we can remove the |
@ruflin I expect that the upgrade process goes like this:
Between steps 1 and 2 there will be 7.x agents sending data to 8.0 stack at the same time with 8.0 agents. |
|
I assume step 1.5 is that the user also needs to ensure to have the most recent k8s package version. |
I have exactly the same understanding. Please proceed with these changes (lower version, no breaking changes). |
mtojek
left a comment
There was a problem hiding this comment.
There are some Git conflicts here.
@mtojek I resolved them |
What does this PR do?
In agent 8.0 a new breaking changed is introduced.
As part of elastic/beats#16483 and after merging of elastic/beats#27917
following changes where introduced:
kubernetes.namespacefrom keyword to group field.kubernetes.namespacewhich was the name of the namespace tokubernetes.namespace.namefield.namespace_labels,namespace_annotationsnamespace_uidmetadata tonamespace.labels,namespace.annotations,namespace.uid.kubernetes integration must also be updated accordingly to support the updated fields.
An ingest pipeline is also added in each updated data_stream to support also agents before 8.0 which may also send data to 8.0 stack. This can happen due to the update process of each user.
In this PR
Kubernetes namespacefield gets updated from keyword to group type andname,labels,annotations,uidare added as fields under it.Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).##Screenshots