Skip to content

entityanalytics_okta: map roles data to ECS #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 2 commits into from
Jul 2, 2025
Merged

entityanalytics_okta: map roles data to ECS #14211

efd6 merged 2 commits into from
Jul 2, 2025

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jun 11, 2025

Proposed commit message

See title.

Note

Marking as bug since it fixes absent mapping and restricts the version to stacks that have the agent feature.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 11, 2025
@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:entityanalytics_okta Okta Entity Analytics labels Jun 11, 2025
@efd6 efd6 force-pushed the 13165-entityanalytics_okta-int branch from 5fea2b9 to 3c12ed7 Compare June 11, 2025 23:35
@efd6 efd6 force-pushed the 13165-entityanalytics_okta-int branch from 3c12ed7 to 6d4d910 Compare June 12, 2025 00:01
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 12, 2025

🚀 Benchmarks report

Package entityanalytics_okta 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
entity 1257.86 980.39 -277.47 (-22.06%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Jun 12, 2025

💚 Build Succeeded

History

cc @efd6

@efd6
Copy link
Contributor Author

efd6 commented Jun 12, 2025

/test stack 9.0.2

@efd6 efd6 marked this pull request as ready for review June 12, 2025 02:03
@efd6 efd6 requested a review from a team as a code owner June 12, 2025 02:03
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 requested a review from hop-dev June 12, 2025 02:03
chemamartinez
chemamartinez reviewed Jun 12, 2025
View reviewed changes
packages/entityanalytics_okta/data_stream/entity/elasticsearch/ingest_pipeline/user.yml
formats:
- ISO8601
on_failure:
- rename:
Copy link
Contributor

@chemamartinez chemamartinez Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a rename here to the original form in the failure case?

Copy link
Contributor Author

@efd6 efd6 Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the format cannot be parsed, this retains the value as a keyword. It prevents non-mapping while retaining data. The alternative is to write the error into error.message. Happy to do the latter if you would prefer.

packages/entityanalytics_okta/data_stream/entity/fields/fields.yml Outdated
description: When the role was last updated.
- name: assignment_type
type: keyword
description: The Okta type the role can is assigned to.
Copy link
Contributor

@chemamartinez chemamartinez Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The Okta type the role can is assigned to.
description: The Okta type the role can be assigned to.

packages/entityanalytics_okta/data_stream/user/fields/fields.yml Outdated
description: When the role was last updated.
- name: assignment_type
type: keyword
description: The Okta type the role can is assigned to.
Copy link
Contributor

@chemamartinez chemamartinez Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The Okta type the role can is assigned to.
description: The Okta type the role can be assigned to.

@efd6 efd6 force-pushed the 13165-entityanalytics_okta-int branch from c3312a8 to f34fabc Compare June 12, 2025 21:24
@efd6 efd6 force-pushed the 13165-entityanalytics_okta-int branch from f34fabc to 6bedcb6 Compare June 12, 2025 23:08
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2025

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jun 12, 2025

Quality Gate failed Quality Gate failed

Failed conditions
75.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

hop-dev
hop-dev approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and can see user.roles being correctly populated 👍

@efd6 efd6 requested a review from chemamartinez June 30, 2025 04:27
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
andrewkroh
andrewkroh approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit e227b47 into elastic:main Jul 2, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 2, 2025

Package entityanalytics_okta - 2.5.1 containing this change is available at https://epr.elastic.co/package/entityanalytics_okta/2.5.1/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Jul 8, 2025
@efd6 @robester0403
entityanalytics_okta: map roles data to ECS (elastic#14211)
a9dea06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hop-dev hop-dev hop-dev approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@chemamartinez chemamartinez Awaiting requested review from chemamartinez

Assignees

@efd6 efd6

Labels

bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:entityanalytics_okta Okta Entity Analytics Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Okta Entity Analytics]: Add the user.roles field to user entities containing their Okta admin role assignments

5 participants

@efd6 @elasticmachine @hop-dev @andrewkroh @chemamartinez