Add missing daemonset.name field #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
Pinging @elastic/integrations (Team:Integrations) |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
mtojek
reviewed
Jul 20, 2021
Contributor
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
Many doc files are deleted. Is it on purpose?
Member
Author
It is on purpose yes. Those files are redundant and should be moved after we moved to input_groups. |
mtojek
approved these changes
Jul 20, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
MichaelKatsoulis
approved these changes
Jul 20, 2021
Member
Author
|
@mtojek shouldn't this be automatically moved to snapshot? I don't see any linked PRs 🤔 |
Contributor
|
It will happen if the CI run for master succeeds: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/master/563/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing daemonset.name field to tune according to elastic/beats#26808.