Skip to content

Conversation

@VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Jan 16, 2025

Closes #12143

Screenshots:
Screenshot 2025-01-21 at 7 22 48 PM
Screenshot 2025-01-21 at 7 22 44 PM

@VihasMakwana VihasMakwana requested a review from a team as a code owner January 16, 2025 11:59
@VihasMakwana VihasMakwana added the integration Label used for meta issues tracking each integration label Jan 16, 2025
@VihasMakwana VihasMakwana self-assigned this Jan 16, 2025
@VihasMakwana VihasMakwana added enhancement New feature or request Integration:linux Linux Metrics labels Jan 16, 2025
@andrewkroh andrewkroh added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jan 16, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@VihasMakwana VihasMakwana force-pushed the linux-integration-9.x branch from ac7f228 to 9669f5d Compare January 16, 2025 14:36
Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but CI is failing.

@VihasMakwana
Copy link
Contributor Author

@jlind23 I've converted it to v3 and fixed all the dashboards (finally 😌). Can you please take another look at screenshots?

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Jan 21, 2025
@VihasMakwana VihasMakwana force-pushed the linux-integration-9.x branch 3 times, most recently from 6527822 to 0cb5033 Compare January 21, 2025 16:22
@VihasMakwana
Copy link
Contributor Author

@leehinman @jsoriano if you can also take a look at these changes, as they are major changes. I'd appreciate your review!

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only didn't check changes in dashboards in detail.

A changelog entry would be needed.

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question about the check exclusion but it isn't a blocker.

@VihasMakwana VihasMakwana requested a review from jsoriano January 23, 2025 06:39
@VihasMakwana
Copy link
Contributor Author

@jsoriano I've added changelog and updated minor version. Can you please take another look?

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #20729 succeeded 0cb5033bf8a1d12778c17a94e35d003aebcaadca
  • 💔 Build #20716 failed 6527822fbc4d6835d378884ff9b6b06585214cf1
  • 💔 Build #20713 failed 812c8d1cc8518e502a257bdee8dae8224b659857
  • 💔 Build #20541 failed 52ed7a3ded799ea74a8634ce5e5bbf8a2ee24158
  • 💔 Build #20533 failed 9669f5dc5228df0dd2a38c88d32337e980fba2a9
  • 💔 Build #20527 failed bdf36f0f4d84fe3795e21352790fcf0fadee6af9

cc @VihasMakwana

@elastic-sonarqube
Copy link

@VihasMakwana VihasMakwana merged commit 4f294e3 into elastic:main Jan 23, 2025
5 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong PR number. Should be 12368.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry 🤦
Here's the fix PR. PTAL!

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* linux integration

* add object_type

* long

* additional property

* release and license

* chore: convert to lens

* update minor version and changelog

* remove validations
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
* linux integration

* add object_type

* long

* additional property

* release and license

* chore: convert to lens

* update minor version and changelog

* remove validations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:linux Linux Metrics integration Label used for meta issues tracking each integration Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Linux integrations

6 participants