Skip to content

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 14, 2025

Proposed commit message

  • Disabled filestream fingerprint (defaults to enabled in 9.0) in goflow2, imperva, proxysg, and syslog_router system tests
  • Exposed filestream options configuration for goflow2, imperva, and proxysg in order to disable fingerprint in the system tests

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

# Stack version must be 9.0.0(-SNAPSHOT)

cd packages/<pkg>
elastic-package test system

Note: I have run each package's system test against the latest 9.0.0-SNAPSHOT and all tests passed.

--- Test results for package: goflow2 - START ---
╭─────────┬─────────────┬───────────┬────────────┬────────┬────────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME  │ RESULT │   TIME ELAPSED │
├─────────┼─────────────┼───────────┼────────────┼────────┼────────────────┤
│ goflow2 │ sflow       │ system    │ filestream │ PASS   │ 2m8.976144917s │
╰─────────┴─────────────┴───────────┴────────────┴────────┴────────────────╯
--- Test results for package: goflow2 - END   ---

--- Test results for package: imperva - START ---
╭─────────┬──────────────┬───────────┬───────────┬────────┬────────────────╮
│ PACKAGE │ DATA STREAM  │ TEST TYPE │ TEST NAME │ RESULT │   TIME ELAPSED │
├─────────┼──────────────┼───────────┼───────────┼────────┼────────────────┤
│ imperva │ securesphere │ system    │ logfile   │ PASS   │ 2m4.819573375s │
│ imperva │ securesphere │ system    │ tcp       │ PASS   │ 2m6.046617958s │
│ imperva │ securesphere │ system    │ tls       │ PASS   │ 2m8.223399708s │
│ imperva │ securesphere │ system    │ udp       │ PASS   │ 2m6.222934083s │
╰─────────┴──────────────┴───────────┴───────────┴────────┴────────────────╯
--- Test results for package: imperva - END   ---

--- Test results for package: proxysg - START ---
╭─────────┬─────────────┬───────────┬───────────┬────────┬─────────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │    TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────┼────────┼─────────────────┤
│ proxysg │ log         │ system    │ logfile   │ PASS   │ 2m10.754771125s │
│ proxysg │ log         │ system    │ tcp       │ PASS   │ 2m12.350897209s │
│ proxysg │ log         │ system    │ tls       │ PASS   │   36.883552916s │
│ proxysg │ log         │ system    │ udp       │ PASS   │ 2m10.295640084s │
╰─────────┴─────────────┴───────────┴───────────┴────────┴─────────────────╯
--- Test results for package: proxysg - END   ---

--- Test results for package: syslog_router - START ---
╭───────────────┬─────────────┬───────────┬────────────┬────────┬────────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME  │ RESULT │   TIME ELAPSED │
├───────────────┼─────────────┼───────────┼────────────┼────────┼────────────────┤
│ syslog_router │ log         │ system    │ filestream │ PASS   │ 2m5.138502875s │
│ syslog_router │ log         │ system    │ tcp        │ PASS   │ 2m9.551055542s │
│ syslog_router │ log         │ system    │ tls        │ PASS   │  37.642996584s │
│ syslog_router │ log         │ system    │ udp        │ PASS   │ 2m8.906954792s │
╰───────────────┴─────────────┴───────────┴────────────┴────────┴────────────────╯
--- Test results for package: syslog_router - END   ---

Related issues

@taylor-swanson taylor-swanson added enhancement New feature or request Integration:imperva Imperva Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Integration:proxysg Broadcom ProxySG Integration:goflow2 GoFlow2 logs (Community supported) Integration:syslog_router Syslog Router labels Jan 14, 2025
@taylor-swanson taylor-swanson self-assigned this Jan 14, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @taylor-swanson

@elastic-sonarqube
Copy link

@taylor-swanson taylor-swanson marked this pull request as ready for review January 15, 2025 17:06
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 15, 2025 17:06
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Contributor

@qcorporation qcorporation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this yesterday in draft. Looks good

@qcorporation qcorporation requested a review from a team January 15, 2025 17:19
@taylor-swanson taylor-swanson merged commit 9dd3857 into elastic:main Jan 15, 2025
5 checks passed
@taylor-swanson taylor-swanson deleted the fix/test-filestream-fingerprint branch January 15, 2025 21:08
@elastic-vault-github-plugin-prod

Package goflow2 - 0.2.0 containing this change is available at https://epr.elastic.co/package/goflow2/0.2.0/

@elastic-vault-github-plugin-prod

Package imperva - 1.2.0 containing this change is available at https://epr.elastic.co/package/imperva/1.2.0/

@elastic-vault-github-plugin-prod

Package proxysg - 0.4.0 containing this change is available at https://epr.elastic.co/package/proxysg/0.4.0/

@elastic-vault-github-plugin-prod

Package syslog_router - 0.1.1 containing this change is available at https://epr.elastic.co/package/syslog_router/0.1.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
)

- Disabled filestream fingerprint (defaults to enabled in 9.0) in
goflow2, imperva, proxysg, and syslog_router system tests
- Exposed filestream options configuration for goflow2, imperva, and proxysg
in order to disable fingerprint in the system tests
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
)

- Disabled filestream fingerprint (defaults to enabled in 9.0) in
goflow2, imperva, proxysg, and syslog_router system tests
- Exposed filestream options configuration for goflow2, imperva, and proxysg
in order to disable fingerprint in the system tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:goflow2 GoFlow2 logs (Community supported) Integration:imperva Imperva Integration:proxysg Broadcom ProxySG Integration:syslog_router Syslog Router Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

Projects

None yet

3 participants