Skip to content

Conversation

@mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Nov 12, 2024

Proposed commit message

In ProxySG integration, add new log format config options to all inputs. Previously, the new formats were added to only one input. These config values need to exist on all inputs, so all can be configured to all supported log formats.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@mjwolf mjwolf added bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Integration:proxysg Broadcom ProxySG labels Nov 12, 2024
@mjwolf mjwolf requested a review from a team as a code owner November 12, 2024 21:02
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Contributor

@qcorporation qcorporation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qcorporation qcorporation requested a review from a team November 12, 2024 21:20
@mjwolf mjwolf force-pushed the proxysg-log-formats branch from 39ac84f to 7b01ed5 Compare November 12, 2024 21:37
Copy link
Contributor

@aleksmaus aleksmaus Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been schooled on this before. The enhancement should increment the minor 0.4.0. The bugfix should increment the patch number 0.3.1. Which is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bugfix, I'll change the type

@mjwolf mjwolf enabled auto-merge (squash) November 12, 2024 22:03
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #18248 failed 39ac84f3af9573b665ac28493c2c0e4a2fd19cc7

@mjwolf mjwolf merged commit dab2986 into elastic:main Nov 12, 2024
5 checks passed
@mjwolf mjwolf deleted the proxysg-log-formats branch November 12, 2024 22:14
@elastic-vault-github-plugin-prod

Package proxysg - 0.3.1 containing this change is available at https://epr.elastic.co/package/proxysg/0.3.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
In ProxySG integration, add new log format config options to all inputs. Previously, the new formats were added to only one input. These config values need to exist on all inputs, so all can be configured to all supported log formats.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
In ProxySG integration, add new log format config options to all inputs. Previously, the new formats were added to only one input. These config values need to exist on all inputs, so all can be configured to all supported log formats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:proxysg Broadcom ProxySG Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants