Skip to content

Conversation

@harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Nov 6, 2024

Proposed commit message

  • Fix single event object returned by evaluation error that causing agent degrade issue for the following data streams
    • hardware
    • process
    • disk

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

Before

image (8)

After

image (7)

@harnish-crest-data harnish-crest-data added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] bugfix Pull request that fixes a bug issue Integration:mongodb_atlas MongoDB Atlas labels Nov 6, 2024
@harnish-crest-data harnish-crest-data self-assigned this Nov 6, 2024
@harnish-crest-data harnish-crest-data marked this pull request as ready for review November 6, 2024 10:21
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner November 6, 2024 10:21
@harnish-crest-data harnish-crest-data marked this pull request as draft November 6, 2024 10:49
@harnish-crest-data
Copy link
Contributor Author

/test

@harnish-crest-data harnish-crest-data force-pushed the mongodb_atlas_error_handling branch from 81b921e to efa3c3a Compare November 7, 2024 05:48
@harnish-crest-data harnish-crest-data marked this pull request as ready for review November 7, 2024 05:49
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #17969 failed 81b921e05b02392249eb90aee9de2e5bd9d0cab7
  • 💔 Build #17965 failed 81b921e05b02392249eb90aee9de2e5bd9d0cab7

cc @harnish-elastic

@elastic-sonarqube
Copy link

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are changing from single event to an array, is there a change in how the event is now formed ?
If yes, lets update the sample json as well

@harnish-crest-data
Copy link
Contributor Author

Since we are changing from single event to an array, is there a change in how the event is now formed ? If yes, lets update the sample json as well

No, there is not a change in the event format!

@harnish-crest-data harnish-crest-data merged commit 9ba56d9 into elastic:main Nov 28, 2024
@efd6
Copy link
Contributor

efd6 commented Nov 28, 2024

@ishleenk17 The relevant part of the input is here. Single events are promoted to an array, but the single event is a signal that the data was an error condition. Also noted here and in the docs.

@elastic-vault-github-plugin-prod

Package mongodb_atlas - 0.0.10 containing this change is available at https://epr.elastic.co/package/mongodb_atlas/0.0.10/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:mongodb_atlas MongoDB Atlas Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mongodb_atlas]: Parsing errors in multiple datasets/datastreams and agent instability in Beta version

4 participants