Skip to content

Bugfix: Fix formulas for computing tier capacity #11480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cp-elastic merged 14 commits into from
Feb 26, 2025
Merged

Bugfix: Fix formulas for computing tier capacity #11480

cp-elastic merged 14 commits into from
Feb 26, 2025

Conversation

@cp-elastic
Copy link
Contributor

@cp-elastic cp-elastic commented Oct 21, 2024

Proposed commit message

Fix formulas for computing tier capacity

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Install version 1.15.1 of this integration, check existing Tier Capacity visualizations, see that they are incorrect due to dividing by unique count of node names instead of multiplying.

@cp-elastic cp-elastic added the bugfix Pull request that fixes a bug issue label Oct 21, 2024
@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:elasticsearch Elasticsearch labels Oct 21, 2024
@cp-elastic cp-elastic marked this pull request as ready for review October 21, 2024 13:57
@cp-elastic cp-elastic requested a review from a team as a code owner October 21, 2024 13:57
@cp-elastic cp-elastic requested a review from consulthys October 21, 2024 13:57
@andrewkroh andrewkroh added the Team:Stack Monitoring Stack Monitoring team [elastic/stack-monitoring] label Oct 21, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 21, 2024 •
edited
Loading

🚀 Benchmarks report

Package elasticsearch 👍(1) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2631.58 1533.74 -1097.84 (-41.72%) 💔
gc 5952.38 3802.28 -2150.1 (-36.12%) 💔
server 7246.38 3571.43 -3674.95 (-50.71%) 💔
slowlog 5847.95 4032.26 -1815.69 (-31.05%) 💔

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Oct 21, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@botelastic
Copy link

botelastic bot commented Nov 20, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 20, 2024
@botelastic
Copy link

botelastic bot commented Dec 20, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Dec 20, 2024
@cp-elastic cp-elastic reopened this Jan 6, 2025
@botelastic botelastic bot removed the Stalled label Jan 6, 2025
@cp-elastic
Copy link
Contributor Author

cp-elastic commented Jan 6, 2025

Reopening this PR as it is still a bug.

@qcorporation qcorporation force-pushed the elasticsearch-fix-dashboard-formulas branch from 837217f to 612f580 Compare February 3, 2025 22:34
@qcorporation qcorporation requested review from a team February 3, 2025 22:34
@qcorporation qcorporation requested review from a team, mauri870 and rdner February 3, 2025 22:34
@andrewkroh andrewkroh added Integration:1password 1Password (Partner supported) Integration:abnormal_security Abnormal AI New Integration Issue or pull request for creating a new integration package. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 3, 2025
@elasticmachine
Copy link

elasticmachine commented Feb 3, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh removed Integration:1password 1Password (Partner supported) Integration:abnormal_security Abnormal AI labels Feb 4, 2025
@qcorporation qcorporation force-pushed the elasticsearch-fix-dashboard-formulas branch from 612f580 to c9b1f8c Compare February 4, 2025 18:13
@qcorporation qcorporation force-pushed the main branch 2 times, most recently from eda4138 to f728ca7 Compare February 5, 2025 22:00
@efd6
Copy link
Contributor

efd6 commented Feb 25, 2025

@cp-elastic Would you mind either syncing this with main or closing it? It is resulting in repeated notifications to multiple teams.

@cp-elastic cp-elastic enabled auto-merge (squash) February 26, 2025 13:05
@cp-elastic
Copy link
Contributor Author

cp-elastic commented Feb 26, 2025

@efd6 My apologies, I didn't see the merge conflicts.
@consulthys would you mind reviewing and merging?

@elasticmachine
Copy link

elasticmachine commented Feb 26, 2025

💚 Build Succeeded

History

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Feb 26, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

consulthys
consulthys approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

@cp-elastic cp-elastic merged commit c357ded into main Feb 26, 2025
6 checks passed
@cp-elastic cp-elastic deleted the elasticsearch-fix-dashboard-formulas branch February 26, 2025 14:05
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Feb 26, 2025

Package elasticsearch - 1.17.4 containing this change is available at https://epr.elastic.co/package/elasticsearch/1.17.4/

@andrewkroh andrewkroh removed the New Integration Issue or pull request for creating a new integration package. label Mar 13, 2025
flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@cp-elastic @flexitrev
Bugfix: Fix formulas for computing tier capacity (#11480)
65f9944 
* Fix formulas for computing tier capacity

* Update changelog with PR

* Revert typeMigrationVersion

* Increment changelog number

* Increment version in manifest

* Remove showApplySelections key

* Fix whitespace in changelog.yml

* Update manifest.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@consulthys consulthys consulthys approved these changes

@rdner rdner Awaiting requested review from rdner rdner was automatically assigned from elastic/elastic-agent-data-plane

@mauri870 mauri870 Awaiting requested review from mauri870 mauri870 was automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:elasticsearch Elasticsearch Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Stack Monitoring Stack Monitoring team [elastic/stack-monitoring]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cp-elastic @elasticmachine @efd6 @consulthys @andrewkroh