[release/9.0-staging] handle case of Proc Index > MAX_SUPPORTED_CPUS#109385
Merged
mangod9 merged 3 commits intorelease/9.0-stagingfrom Nov 6, 2024
Merged
[release/9.0-staging] handle case of Proc Index > MAX_SUPPORTED_CPUS#109385mangod9 merged 3 commits intorelease/9.0-stagingfrom
mangod9 merged 3 commits intorelease/9.0-stagingfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
jeffschwMSFT
approved these changes
Oct 30, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
jeffschwMSFT
added
the
Servicing-consider
Maoni0
approved these changes
Oct 30, 2024
jeffschwMSFT
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #109295 to release/9.0-staging
/cc @mangod9
Customer Impact
The issue occurs mainly when running a x86 .NET app with ServerGC on a machine with > 64 cores. If the app is scheduled to run on the higher cpu group it could lead to an AV.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Verified locally on a machine with >64 cores. Additionally support and customer has validated the fix.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.