-
Notifications
You must be signed in to change notification settings - Fork 821
TestsReportGenerator: Always show the error message, and truncate only the stdout #9335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
77e8d0e
TestsReportGenerator: Always show the error message, and truncate onl…
radical 1245321
Update tools/GenerateTestSummary/TestSummaryGenerator.cs
radical 9300379
Address review feedback from @ danmoseley .
radical 34a6466
Quarantine Aspire.Hosting.Tests.DistributedApplicationTests.TestServi…
radical cfa668a
Quarantine YarpFunctionalTests.VerifyYarpResource - https://github.co…
radical File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,21 +144,31 @@ public static void CreateSingleTestSummaryReport(string trxFilePath, StringBuild | |
|
|
||
| """); | ||
|
|
||
| var errorMsgBuilder = new StringBuilder(); | ||
| errorMsgBuilder.AppendLine(test.Output?.ErrorInfo?.InnerText ?? string.Empty); | ||
| reportBuilder.AppendLine(); | ||
| reportBuilder.AppendLine("```yml"); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yml? do you mean text maybe?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That seems to provide a nice coloring! |
||
|
|
||
| reportBuilder.AppendLine(test.Output?.ErrorInfo?.InnerText); | ||
| if (test.Output?.StdOut is not null) | ||
| { | ||
| errorMsgBuilder.AppendLine(); | ||
| errorMsgBuilder.AppendLine("### StdOut"); | ||
| errorMsgBuilder.AppendLine(test.Output.StdOut); | ||
| const int halfLength = 25_000; | ||
| var stdOutSpan = test.Output.StdOut.AsSpan(); | ||
|
|
||
| reportBuilder.AppendLine(); | ||
| reportBuilder.AppendLine("### StdOut"); | ||
|
|
||
| var startSpan = stdOutSpan[..Math.Min(halfLength, stdOutSpan.Length)]; | ||
| reportBuilder.AppendLine(startSpan.ToString()); | ||
|
|
||
| if (stdOutSpan.Length > halfLength) | ||
| { | ||
| reportBuilder.AppendLine(CultureInfo.InvariantCulture, $"{Environment.NewLine}... (snip) ...{Environment.NewLine}"); | ||
| var endSpan = stdOutSpan[^halfLength..]; | ||
| // `endSpan` might not begin at the true beginning of the original line | ||
| reportBuilder.Append("... "); | ||
| reportBuilder.Append(endSpan); | ||
| } | ||
| } | ||
|
|
||
| // Truncate long error messages for readability | ||
| var errorMsgTruncated = TruncateTheStart(errorMsgBuilder.ToString(), 50_000); | ||
|
|
||
| reportBuilder.AppendLine(); | ||
| reportBuilder.AppendLine("```yml"); | ||
| reportBuilder.AppendLine(errorMsgTruncated); | ||
| reportBuilder.AppendLine("```"); | ||
| reportBuilder.AppendLine(); | ||
| reportBuilder.AppendLine("</div>"); | ||
|
|
@@ -181,9 +191,4 @@ public static string GetTestTitle(string trxFileName) | |
|
|
||
| [GeneratedRegex(@"(?<testName>.*)_(?<tfm>net\d+\.0)_.*")] | ||
| private static partial Regex TestNameFromTrxFileNameRegex(); | ||
|
|
||
| private static string? TruncateTheStart(string? s, int maxLength) | ||
| => s is null || s.Length <= maxLength | ||
| ? s | ||
| : "... (truncated) " + s[^maxLength..]; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.