Fix unhandled ParameterType case for binary PKs #12062
Merged
+273
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper handling for binary primary key parameter types that were previously causing runtime exceptions. The existing parameter type switch statement was missing a case for binary types, leading to unhandled scenarios when working with binary primary keys. This ensures consistent parameter type handling across all supported primary key data types in the ORM.
greg0ire
previously approved these changes
Jul 9, 2025
SenseException
previously approved these changes
Jul 9, 2025
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
greg0ire
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply of #12042 (comment)