Do not crash on UTF-8 decode errors #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't actually tested the changes yet but I can try later when I have more time. |
|
This looks good, will merge if it's tested |
|
Tested it out here on a program that had been causing |
|
Sorry, I moved to other projects and haven't used gdbgui or even gdb since, I don't have a reproduction example anymore. |
|
I meant that I can provide the source to reproduce the issue. Your patch did work very well on my machine, at least, so it has that going for it. |
|
You can paste the source here. |
cs01
approved these changes
Oct 18, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md, or an entry is not needed for this changeSummary of changes
This PR implements a fix suggested in #407.
There are also other UTF-8 issues that might be related to this:
#130
#347
#292
Test plan
Tested by running