Skip to content

remove old extension file before building new php version #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

henderkes
Copy link
Collaborator

What does this PR do?

I would like to integrate this into the LockFile somehow, but I'm not sure how.

please feel free to move it to the right location

@henderkes henderkes requested a review from crazywhalecc June 19, 2025 11:13
@crazywhalecc
Copy link
Owner

Currently LockFile is only managing source and downloads, it's not managing buildroot.

How about deleting the module directory here only if it is detected that this build contains a shared extension?

@henderkes
Copy link
Collaborator Author

if it doesn't contain a shared extension, I don't think it's even created in the first place, so that would only add unnecessary code

Copy link
Owner

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, it seems appropriate to delete it here.

@henderkes henderkes merged commit c3b520c into main Jun 19, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants