Sapi/frankenphp #772
Sapi/frankenphp #772
Conversation
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
{craft}
extensions: bcmath
shared-extensions: xdebug,swoole
sapi: cli
{/craft}
[spc_prefix:bin/spc-gnu-docker]
…ing frankenphp after compiling a different version
|
Hahaha, I found a frankenphp bug. The php-server directive unconditionally enables brotli encoding. |
Sapi/frankenphp prerequisites
…addy is meant to do both in one step
| @@ -42,6 +42,9 @@ SPC_CONCURRENCY=${CPU_COUNT} | |||
| SPC_SKIP_PHP_VERSION_CHECK="no" | |||
| ; Ignore some check item for bin/spc doctor command, comma separated (e.g. SPC_SKIP_DOCTOR_CHECK_ITEMS="if homebrew has installed") | |||
| SPC_SKIP_DOCTOR_CHECK_ITEMS="" | |||
| ; extra modules that xcaddy will include in the FrankenPHP build | |||
| SPC_CMD_VAR_FRANKENPHP_XCADDY_MODULES="--with github.com/dunglas/frankenphp/caddy --with github.com/dunglas/mercure/caddy --with github.com/dunglas/vulcain/caddy --with github.com/dunglas/caddy-cbrotli" | |||
There was a problem hiding this comment.
Are these modules required all the time? If so, it would be better to add them as dependencies directly.
There was a problem hiding this comment.
They are used in the official frankenphp build, so I set it as an overridable option.
I personally build without vulcain but with caddy cache and supervisor.
There was a problem hiding this comment.
(also, again, can't download them earlier as it's part of xcaddy's process)
|
Oh, we merge into the docs branch? |
Yeah, like I said earlier, I don't think there's a good way. It will have to do some downloading every time we build (it also updates modules every time), the only way around that would be incredibly tedious by not going with xcaddy at all. |
yes, it needs some changes I've made there for the packaging to even work properly |
But I haven't fully reviewed the docs branch yet, and it seems there are some unfinished parts. |
I don't think so. These changes here more or less complete it. This branch was based off of the docs branch in the first place, it has all of its changes in here. |
What does this PR do?
adds support for the FrankenPHP sapi (linux, macos, bsd)
Checklist before merging
*.php, runcomposer cs-fixat local machine.src/global/test-extensions.php../docs/.config/xxx.jsoncontent, runbin/spc dev:sort-config xxx.