-
-
Notifications
You must be signed in to change notification settings - Fork 304
Feat: UnixCMakeExecutor #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you also change execWithEnv to put the environment silently in prod mode and only print the executed command without environment flags? For debug mode I think we should print all environment flags we use, so pkg_config and pkg_config_path as well. |
Co-authored-by: Marc <m@pyc.ac>
Co-authored-by: Marc <m@pyc.ac>
I will do it next PR. |
Could you base the next PR off of my PR by chance? This one will have quite a few conflicts, but the next will have even more. |
I plan to start resolving #726 conflicts after the next setEnv PR. This will make it clearer how we should modify the giant PR. I've already done part of it, and it seems like basing the next PR on it will lead to even more confusion. Maybe breaking up parts of #726 into smaller PRs and merging them into the main branch first would be clearer. |
Yeah that's fair. |
What does this PR do?
Replace all cmake builder to cmake executor. After refactoring we can control all cmake build process instead of updating every single file every time. This is one of prerequisites for #726 .
After this PR is merged, it will continue to:
setDefaultEnv()
for UnixShell to replace the redundantsetEnv(['XXXFLAGS'])
, remove redundantexecWithEnv()
.Checklist before merging
*.php
, runcomposer cs-fix
at local machine.