-
-
Notifications
You must be signed in to change notification settings - Fork 304
enable PDO_ODBC and ODBC extension statically #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable PDO_ODBC and ODBC extension statically #661
Conversation
If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php. other than that, looks good |
Do all extension to be added into the I am working on |
We add the extensions currently worked on to test-extensions. Isn't the bulk option for librariest? If it also affects extensions yes it should be added. |
Thank you for your contribution. I'll take over to add some tests and docs if you don't mind. |
Added the extensions to the test-extensions script. @crazywhalecc thank you for doing the docs and tests. Then its ready. If there is anything to be done, let me know. |
I reverted bulk changes because there is no point in modifying the fixed combination here. The real Usually we don't change combination. But if you think it's necessary to add odbc to example bulk combination, you can make another CI update PR in "hosted" repo and add here again. |
7239fba
to
0bc143c
Compare
I think you want to revert that force push x) |
reset back to 7239fba and push again |
Sorry, there went someting horrible wrong.. Clean up and re-committed and pushed. What do you prefer for the test, or should I leave it for @crazywhalecc? |
If anything else has done, I'll add it to tests later. |
it works for Windows as well, so no need for WIP in the docs. Everything should be done |
…odbc' into feat/enable-odbc-and-pdo-odbc # Conflicts: # src/globals/test-extensions.php
# Conflicts: # src/globals/test-extensions.php
What does this PR do?
Enabling the PHP extensions
ODBC
andPDO_ODBC
.Checklist before merging
*.php
, runcomposer cs-fix
at local machine.src/global/test-extensions.php
../docs/
.config/xxx.json
content, runbin/spc dev:sort-config xxx
.