Skip to content

enable PDO_ODBC and ODBC extension statically #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yoramdelangen
Copy link
Contributor

What does this PR do?

Enabling the PHP extensions ODBC and PDO_ODBC.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@henderkes
Copy link
Collaborator

If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.

other than that, looks good

@yoramdelangen
Copy link
Contributor Author

yoramdelangen commented Mar 19, 2025

Do all extension to be added into the globals/test-extensions.php? Shall I added it to the 'bulk' set?. Do you want me to update the extensions docs as well?

I am working on pgsql for Windows as well, its almost done

@henderkes
Copy link
Collaborator

We add the extensions currently worked on to test-extensions.

Isn't the bulk option for librariest? If it also affects extensions yes it should be added.

@crazywhalecc crazywhalecc added new feature New feature or request kind/extension Issues related to extensions labels Mar 20, 2025
@crazywhalecc
Copy link
Owner

Thank you for your contribution. I'll take over to add some tests and docs if you don't mind.

@yoramdelangen
Copy link
Contributor Author

Added the extensions to the test-extensions script. @crazywhalecc thank you for doing the docs and tests. Then its ready. If there is anything to be done, let me know.

@crazywhalecc
Copy link
Owner

crazywhalecc commented Mar 20, 2025

I reverted bulk changes because there is no point in modifying the fixed combination here. The real bulk combination is set in static-php-cli-hosted repo and this tests is only for easy reference.

Usually we don't change combination. But if you think it's necessary to add odbc to example bulk combination, you can make another CI update PR in "hosted" repo and add here again.

@yoramdelangen yoramdelangen force-pushed the feat/enable-odbc-and-pdo-odbc branch from 7239fba to 0bc143c Compare March 20, 2025 08:40
@henderkes
Copy link
Collaborator

I think you want to revert that force push x)

@henderkes
Copy link
Collaborator

reset back to 7239fba and push again

@henderkes
Copy link
Collaborator

@yoramdelangen

@yoramdelangen yoramdelangen reopened this Mar 20, 2025
@yoramdelangen
Copy link
Contributor Author

yoramdelangen commented Mar 20, 2025

Sorry, there went someting horrible wrong.. Clean up and re-committed and pushed.
Let me verify the WIP for windows though.. because it should work on Windows as well, only the odbc I haven't verified entirely yet

What do you prefer for the test, or should I leave it for @crazywhalecc?

@crazywhalecc
Copy link
Owner

If anything else has done, I'll add it to tests later.

@yoramdelangen
Copy link
Contributor Author

it works for Windows as well, so no need for WIP in the docs. Everything should be done

…odbc' into feat/enable-odbc-and-pdo-odbc

# Conflicts:
#	src/globals/test-extensions.php
@crazywhalecc crazywhalecc merged commit 3ba215c into crazywhalecc:main Mar 23, 2025
4 checks passed
@yoramdelangen yoramdelangen deleted the feat/enable-odbc-and-pdo-odbc branch March 24, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/extension Issues related to extensions new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants