-
-
Notifications
You must be signed in to change notification settings - Fork 304
Switch static-php-cli to support PHP 8.3 and 8.4 only #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
At present, at least common distributions (Ubuntu, Alpine, Fedora) cannot directly install PHP8.4 through package management. Reducing it to 8.3~8.4 may be a compromise solution. |
RHEL still installs 8.0 by default and doesn't have 8.2+ in the main rpm repo. I don't think we need to shackle ourselves to ancient versions just because users will have to enable extra modules in one command. You've said it yourself, SPC is not a library. The only people this change should concern are developers who are working on SPC. |
That's true. But I still think that the restrictions in composer.json should not be too strict. We have already fully used and required the latest version in the documentation, workflow and |
Technically true, but allowing php 8.3 will require us to stay at 8.3 level in the code and doesn't provide any real benefit. Who benefits from 8.3 support? Are there any developers working on this project who must use their systems php version and cannot update it to 8.4? The only people this would possibly concern are people who use the main branch of this project in one of their deployment routines. Which is a bad idea, so that's not something we should consider. In the end, it's up to you. If you believe that there are developers contributing to SPC who cannot install php 8.4, but 8.3, then keep support for it. |
I know this is a rather inconsistent decision, but I don't want to cause a version upgrade to break the workflow of most downstream projects. One of my private project, FrankenPHP, Herd, and some project forks etc. seem to be built using 8.3. If it is forced to limit to 8.4, related projects will also need to update the compilation script immediately, or completely use For PHP 8.3, I think the following measures can be taken to gradually transition:
|
Yes and no at the same time. They all require specific commits of this repository, so nothing would change immediately. They would continue to work just fine. Only when they update the SPC tag they use, they would also have to update their jobs from 8.3 to 8.4.
Yes, that's a good idea.
I don't think that's reasonable. We don't know all the downstream project and we don't know when they even plan to update the SPC release they use.
Good idea. |
Updated |
What does this PR do?
Switch static-php-cli to support 8.3 and 8.4 only.
The reasons for this are:
spc
that does not require a PHP environment.Checklist before merging
src/global/test-extensions.php
../docs/
.config/xxx.json
content, runbin/spc dev:sort-config xxx
.