Skip to content

Fix/thinpool detection as it allows to delete active thinpool with different name than "data" #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2025
Merged

Fix/thinpool detection as it allows to delete active thinpool with different name than "data" #6730

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
304b39c
Fix: exclude all thin-pools dynamically instead of only 'data'
onethree7 Aug 10, 2025
5d917a8
Fix: dynamically exclude all thin pools (not just 'data') from orphan…
onethree7 Aug 10, 2025
e01140c
Fix: dynamically exclude all thin pools (not just 'data') from orphan…
onethree7 Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix: exclude all thin-pools dynamically instead of only 'data'
  • Loading branch information
@onethree7
onethree7 committed Aug 10, 2025
commit 304b39c7e9d7452a1ee479bf52776053c9dc8f1f
25 changes: 14 additions & 11 deletions tools/pve/clean-orphaned-lvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,39 @@
function header_info {
clear
cat <<"EOF"
____ ________ ____ __ __ __ _ ____ ___
____ ________ ____ __ __ __ _ ____ ___
/ __ \_________ _ ______ ___ ____ _ __ / ____/ /__ ____ _____ / __ \_________ / /_ ____ _____ ___ ____/ / / /| | / / |/ /____
/ /_/ / ___/ __ \| |/_/ __ `__ \/ __ \| |/_/ / / / / _ \/ __ `/ __ \ / / / / ___/ __ \/ __ \/ __ `/ __ \/ _ \/ __ / / / | | / / /|_/ / ___/
/ ____/ / / /_/ /> </ / / / / / /_/ /> < / /___/ / __/ /_/ / / / / / /_/ / / / /_/ / / / / /_/ / / / / __/ /_/ / / /__| |/ / / / (__ )
/_/ /_/ \____/_/|_/_/ /_/ /_/\____/_/|_| \____/_/\___/\__,_/_/ /_/ \____/_/ / .___/_/ /_/\__,_/_/ /_/\___/\__,_/ /_____/___/_/ /_/____/
/_/
/ /_/ / ___/ __ \| |/_/ __ __ \/ __ \| |/_/ / / / / _ \/ __ / __ \ / / / / ___/ __ \/ __ \/ __ / __ \/ _ \/ __ / / / | | / / /|_/ / ___/
/ ____/ / / /_/ /> </ / / / / / /_/ /> < / /___/ / __/ /_/ / / / / / /_/ / / / /_/ / / / / /_/ / / / / __/ /_/ / / /__| |/ / / / (__ )
/_/ /_/ \____/_/|_/_/ /_/ /_/\____/_/|_| \____/_/\___/\__,_/_/ /_/ \____/_/ / .___/_/ /_/\__,_/_/ /_/\___/\__,_/ /_____/___/_/ /_/____/
/_/
EOF
}

# Function to check for orphaned LVM volumes
function find_orphaned_lvm {
echo -e "\n🔍 Scanning for orphaned LVM volumes...\n"

orphaned_volumes=()
while read -r lv vg size; do
while read -r lv vg size seg_type; do
# Exclude system-critical LVs and Ceph OSDs
if [[ "$lv" == "data" || "$lv" == "root" || "$lv" == "swap" || "$lv" =~ ^osd-block- ]]; then
continue
fi

# Exclude thin pools only (seg_type == thin-pool)
if [[ "$seg_type" == "thin-pool" ]]; then
continue
fi

container_id=$(echo "$lv" | grep -oE "[0-9]+" | head -1)
# Check if the ID exists as a VM or LXC container
if [ -f "/etc/pve/lxc/${container_id}.conf" ] || [ -f "/etc/pve/qemu-server/${container_id}.conf" ]; then
continue
fi

orphaned_volumes+=("$lv" "$vg" "$size")
done < <(lvs --noheadings -o lv_name,vg_name,lv_size --separator ' ' | awk '{print $1, $2, $3}')
done < <(lvs --noheadings -o lv_name,vg_name,lv_size,seg_type --separator ' ' 2>/dev/null | awk '{print $1, $2, $3, $4}')

# Display orphaned volumes
echo -e "❗ The following orphaned LVM volumes were found:\n"
printf "%-25s %-10s %-10s\n" "LV Name" "VG" "Size"
printf "%-25s %-10s %-10s\n" "-------------------------" "----------" "----------"
Expand All @@ -45,7 +50,6 @@ function find_orphaned_lvm {
echo ""
}

# Function to delete selected volumes
function delete_orphaned_lvm {
for ((i = 0; i < ${#orphaned_volumes[@]}; i += 3)); do
lv="${orphaned_volumes[i]}"
Expand All @@ -67,7 +71,6 @@ function delete_orphaned_lvm {
done
}

# Run script
header_info
find_orphaned_lvm
delete_orphaned_lvm
Expand Down