Skip to content

Refactor: migrate AdventureLog update to uv and GitHub release logic #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

MickLesk
Copy link
Member

✍️ Description

This PR refactors the update_script for AdventureLog to use the standardized fetch_and_deploy_gh_release logic and migrates old installations to the new uv-based Python environment.
It also adds support for version tracking via ~/.adventurelog, ensuring updates are applied even when no local version file exists.

Key changes:

  • Replace manual GitHub release handling with fetch_and_deploy_gh_release
  • Detect and migrate legacy python3/pip setups to uv venv
  • Introduce version tracking using ~/.adventurelog
  • Ensure idempotent update logic with fallback if version file is missing

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@MickLesk MickLesk requested a review from a team as a code owner June 20, 2025 08:32
@github-actions github-actions bot added refactor update script A change that updates a script labels Jun 20, 2025
@tremor021 tremor021 merged commit f81f7fb into main Jun 20, 2025
2 checks passed
@MickLesk MickLesk mentioned this pull request Jun 24, 2025
10 tasks
@MickLesk MickLesk deleted the uv_adventurelog branch June 24, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants