-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Update history api to array #8890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ric-yu
wants to merge
13
commits into
comfyanonymous:master
Choose a base branch
from
ric-yu:update-history-api-to-array
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+428
−2
Draft
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
80ea3d8
Add ordered history API endpoint with deprecation warnings
richyu 4a21727
make execution.py more pythonic
ric-yu 565b537
remove prompt[2] and prompt[4] from history_v2 response
ric-yu a2b8688
remove unused "completed" and cached node info from history_v2 response
ric-yu fdc2a53
remove workflow json from history_v2 response - client will need to u…
ric-yu 36e7363
return prompt as dict rather than array
ric-yu 0609136
deep copy history
ric-yu c9a5ecd
update /history_v2/:prompt_id to also have prompts in dict fmt
ric-yu e79f925
document the api output - it's not very clear
ric-yu b8963ef
clean up comments
ric-yu 72ec6ce
create new dict instead of deepcopy
ric-yu b64df11
remove extra comments
ric-yu 94684db
fix lint
ric-yu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update /history_v2/:prompt_id to also have prompts in dict fmt
- Loading branch information
commit c9a5ecd18480a260c2678f1637bd9c448eb00f6c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we agreed we'd update this endpoint as well cc: @guill @webfiltered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was specifically my recommendation to avoid a case where people need to remember to use one endpoint for the list and one for individual items (which goes against normal REST principles). It's much easier if we're just able to say "move to this new endpoint as we'll be deprecating
/historyeventually".I don't have a strong opinion on the specific name we use, but do strongly feel we should keep this route to preserve consistency.