Drop Twig 1 support#238
Drop Twig 1 support#238florianeckerstorfer merged 2 commits intococur:masterfrom FabienPapet:fix-twig-3.0
Conversation
|
@florianeckerstorfer I'm not happy with that solution but I think it's the best way to have all twig versions working with any version of slugify. This code works on twig 3. I didn't wrote any test, I don't know how to test it. |
|
Should we just drop support for Twig 2? |
|
The real problem is twig 1 here I think. If I remember correctly , twig 2 is supporting old and new namespaces. We can make a version that supports only twig ~2.0|~3.0 What do you think ? |
|
@FabienPapet From my perspective this would be totally fine. Once we have Twig 3 support in, I would release a new major version. People who need support for old frameworks would need to use an old version of the library |
| "ext-mbstring": "*" | ||
| }, | ||
| "conflict": { | ||
| "twig/twig": ">=1,<1.38.1 || >=2,<2.12.1" |
There was a problem hiding this comment.
Since twig/twig is not in the require section, shouldn't this be something like this (in conflict)?
"twig/twig": "<2.12.1"
And I just realised I should've done the same for Symfony < 3.4, I'll make a PR
|
Thanks for the PR, can you resolve the conflict, then I merge it and release a new version over the weekend |
3 participants
No description provided.