[pull] master from LibreOffice:master#12
Merged
pull[bot] merged 11 commits intochenlong622:masterfrom Aug 20, 2025
Merged
Conversation
For Windows build, explicitly define HAVE_FILESYSTEM which forces orcus to use std::filesystem for all filesystem related operations. Also, pass to the ctor of orcus::file_content a filepath as std::u16string_view on Windows to hopefully correctly handle unicode filepaths. Change-Id: Ie6f5403212e73c81f1a36db0413133d26a3a67f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189892 Reviewed-by: Kohei Yoshida <kohei@libreoffice.org> Tested-by: Jenkins
now that Bitmap supports transparency Change-Id: I37d358db5b68cd500349f1084eb3a65cfd83aa4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189898 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
now that Bitmap can handle transparency. This points out a bug in Bitmap::Modify Change-Id: I4774727d235493fdaad054cf36f2d2a36b1db32d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189936 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
...assuming that it was that single occurrence of "/" in
BinaryFunctionExpression::getValue that prompted the
__attribute__((no_sanitize("float-divide-by-zero"))) on that function in
6e4fc05 "ofz#3889 Divide-by-zero"
Change-Id: If3fc6bd8811bb583b898aa6eaf67f30593ba7b72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189916
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
On read only pdfs opened with PDFium send the data (position and uri) of link annotations in each page so the behavior of having clickable links even in a read only document can be emulated. Change-Id: I40bb22b9f6b2f9f9cd8be13c0639faec48ce82d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189920 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I819d08876eb53238692d80030248fe8dc177409e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189929 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
and cid#1664874 Overflowed integer argument Change-Id: I7b1000f0032bd70f53e09de44815f13f55489a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189931 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Idcddf4e576bb74f241c532fbf66b8772f3cd1c6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189932 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
restore the lock at the end of SerfLockStore::stopTicker SerfLockStore::removeLockImpl calls this, and that is called by SerfLockStore::refreshLocks in a loop, so if it was unlocked at the end of the first loop, then its still unlocked on a 2nd loop. Probably doesn't matter as there's only a 2nd unlock attempt if m_aLockInfoMap.empty() which presumably can only happen once. Change-Id: Iede91b1b4ef9368bcf4e62cb85bf5a0c745e0ba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189058 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
follow-up for https://gerrit.libreoffice.org/c/core/+/188451 (f84f8f2) - added a unittest for xmlMaps.xml and <xmlColumnPr> - removed unused aContent variable. - this was causing the tests to fail to load the bugdoc during createScDoc("...") - change Target="/xl/xmlMaps.xml" to Target="xmlMaps.xml" in xl/_rels/workbook.xml.rels - change xmlns attribute to xmlns:x in xl/tables/table[n].xml - add XmlColumnPrModel and TableColumnModel - these Models can be used for implementing sub-elements. Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I5e6ad575b7071f3cf4decb5d90d418b9c54ba107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I58ed464b9f49ddf12f21995f08a8a70f430e2669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189930 Reviewed-by: Michael Stahl <michael.stahl@collabora.com> Tested-by: Jenkins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )