Skip to content

Conversation

adam-nielsen
Copy link
Contributor

@adam-nielsen adam-nielsen commented Dec 1, 2021

There is a bug in the query callback handling (e.g. #1860 #2560) but the test code doesn't pick it up. This change ensures that code path runs in the tests, so it will probably make the tests fail until the bug is fixed. (I say 'probably' because the exception doesn't get thrown until after all the tests have completed successfully.)

node-postgres/packages/pg-cursor/node_modules/mocha/lib/runner.js:911
    throw err;                                                               
    ^                                                                        
                                                                             
TypeError: queryCallback is not a function                                   
    at Timeout._onTimeout (node-postgres/packages/pg-cursor/node_modules/pg/lib/client.js:532:9)
    at listOnTimeout (node:internal/timers:557:17)                           
    at processTimers (node:internal/timers:500:7)

This causes the tests to fail due to a bug in callback handling.
@brianc
Copy link
Owner

brianc commented Dec 10, 2021

The weird thing is github actions isn't running on this PR. :( I might not have added the right thing to it to run on a pull or something...I'll have to look into that.

@brianc
Copy link
Owner

brianc commented Dec 10, 2021

Thanks for this btw! And sorry for the delay: was out of town until last night.

@darkgl0w
Copy link
Contributor

darkgl0w commented Dec 10, 2021

@brianc you must add on: [push, pull_request] to the ci.yml config file to run on a PR ^^

@brianc
Copy link
Owner

brianc commented Dec 10, 2021

@brianc you must add on: [push, pull_request] to the ci.yml config file to run on a PR ^^

roger, wilco!

@avivshafir
Copy link

@brianc is there any solution to this bug?

@yaverin

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants