twoliter: fix make command trailing varargs#148
Merged
webern merged 1 commit intobottlerocket-os:developfrom Jan 30, 2024
Merged
twoliter: fix make command trailing varargs#148webern merged 1 commit intobottlerocket-os:developfrom
webern merged 1 commit intobottlerocket-os:developfrom
Conversation
Fixes issue bottlerocket-os#139. Clap was not configured correctly such that trailing arguments intended to be passed along to the cargo make invocation were not handled correctly. This commit fixes it and adds regression tests in case we change the command arguments or Clap changes behavior.
ecpullen
approved these changes
Jan 30, 2024
gthao313
approved these changes
Jan 30, 2024
sam-berning
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #139
Description of changes:
Fixes issue #139. Clap was not configured correctly such that trailing arguments intended to be passed along to the cargo make invocation were not handled correctly. This commit fixes it and adds regression tests in case we change the command arguments or Clap changes behavior.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.