migrator: end-to-end test#956
migrator: end-to-end test#956webern merged 2 commits intobottlerocket-os:developfrom webern:migrator-test
Conversation
Re-organize using
Rebase. Still need to fix an oops in Cargo.toml |
Fix an oops in |
Fix another oops (actually remove the test from |
Organizes the test in the way that @tjkirch recommend (once I finally understood!) Also uses the new version of pentacle and uses a script instead of calling out to rustc
Deletes a stray file. I still need to go through comments from #930 and try to transfer any of them over to here. |
Forgot a thing in Cargo.toml |
Gawd, sorry for the flailage. This one should actually have the changes that include pentacle and uses a bash script. I have too many branches on too many machines! |
tjkirch
left a comment
There was a problem hiding this comment.
LGTM assuming your remaining checks.
Fixes a couple of @tjkirch comments. |
Fix a comment. |
Moves |
|
tjkirch
left a comment
There was a problem hiding this comment.
Would you please confirm in the testing section that you ran an instance and checked the data store that storewolf creates? (And normal behavior we test...)
Restore Option in storewolf function. |
rebase develop |
Change a comment. |
Issue number:
Related to #91 #905 #930
Description of changes
Move most everything to
src/run.rsand add a filesrc/run_tests.rswhich contains a migrator end-to-end test.Testing done:
Ran the unit tests. Also ran a Bottlerocket instance and did an upgrade/downgrade test with test migrations.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.