TextPipeline::queue_text refactor
#21342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r so it can use it in a call to `TextPipeline::update_buffer`. It then replaces it when the function exits. This is a bit fragile, instead replace it immediately after calling `update_buffer` and then access it using `self` for the rest of the function.
ickshonpe
added
C-Code-Quality
dloukadakis
suggested changes
Oct 2, 2025
Co-authored-by: Dimitrios Loukadakis <dloukadakis@users.noreply.github.com>
dloukadakis
approved these changes
Oct 2, 2025
dloukadakis
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Oct 6, 2025
tigregalis
pushed a commit
to tigregalis/bevy
that referenced
this pull request
Oct 7, 2025
# Objective `TextPipeline::queue_text` temporarily `take`s the buffer from its `glyph_info` field, so that it can be used in a call to `TextPipeline::update_buffer`. It then replaces it when the function exits. This is a bit fragile, as the function has two exit points. ## Solution Replace it immediately after calling `update_buffer`, and then access it with `self` for the rest of the function. --------- Co-authored-by: Dimitrios Loukadakis <dloukadakis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TextPipeline::queue_texttemporarilytakes the buffer from itsglyph_infofield, so that it can be used in a call toTextPipeline::update_buffer. It then replaces it when the function exits. This is a bit fragile, as the function has two exit points.Solution
Replace it immediately after calling
update_buffer, and then access it withselffor the rest of the function.