Simplify UI layout tests#21081
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Dec 16, 2025
Merged
Conversation
…ly instead of creating dummy window render targets.
alice-i-cecile
added
A-UI
alice-i-cecile
approved these changes
Sep 16, 2025
alice-i-cecile
added
C-Code-Quality
rossleonardy
approved these changes
Nov 12, 2025
Contributor
rossleonardy
left a comment
rossleonardy
left a comment
There was a problem hiding this comment.
Makes sense to get window out of here
pablo-lua
added
S-Ready-For-Final-Review
Member
|
@ickshonpe more merge conflicts, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The UI layout tests use dummy
Windowentities and a systemupdate_cameras_test_systemthat updates the camera target info from the dummy windows. We can simplify the tests, and make them less fragile, by setting the camera'sComputedCameraValuesandRenderTargetInfodirectly.Solution
Windowentities, anyWindowqueries, andupdate_cameras_test_system.ui_node_should_properly_update_when_changing_target_cameratest and manually set the camera's viewport values. The logic for the other tests is unchanged.This ended up one line longer in total, but it's just because of white space added by formatting around the nested camera value declarations.
Testing
The tests still pass.