Bumped the JSDOM version in order to fix memory leak #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvinus
added a commit
that referenced
this pull request
Dec 6, 2012
Bumped the JSDOM version in order to fix memory leak
|
Possible NPM Publish? |
|
done :) thx for the patch! |
|
Martin you should also check out the latest 0.2.2 which includes a test for memory leaks and adds the autoWindowClose option. cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory usage would just grow and grow prior to this change. I'd love to get this npm published if possible.
There is one sideeffect. They changed the way the path evaluates on windows which effects the a.href value in the DOM. Now it appears as file:///C:/path/to/file